The collection of buttons definitely predated the Depression.  For example,
the button box of my grandmother, who also was born in the 1880s, contained a
huge collection of 19th century buttons, and included numerous Confederate
uniform buttons.
Also, in addition to other types of material culture, excavations of root
cellars in 18/19th century slave quarters in the Chesapeake region have
revealed significant quantities of buttons.